Fixed conflicting variable names in readPropertyForNode:parent:isExtraProp:#8
Open
richard-sim wants to merge 2 commits intococos2d:masterfrom
Open
Fixed conflicting variable names in readPropertyForNode:parent:isExtraProp:#8richard-sim wants to merge 2 commits intococos2d:masterfrom
richard-sim wants to merge 2 commits intococos2d:masterfrom
Conversation
…erpolation (when going from A->B, B would always be used even if not at that point in the timeline yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readPropertyForNode:parent:isExtraProp: has variables named 'type' declared at both the outermost level, and nested within; this will cause build warnings/errors if HiddenLocalVariables warning is turned on in the project settings. The warning's description makes it sound like it's alerting you to the fact that you are getting unintended behaviour - so I fixed it.